Repository navigation
Allow __init__ and __new__ to return NoReturn - #13480
Merged
Merged
Conversation
Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pylint (https://github.com/pycqa/pylint)
+ pylint/__init__.py:60: error: Unused "type: ignore" comment
+ pylint/pyreverse/main.py:214: error: Unused "type: ignore" comment
|
hauntsaninja
approved these changes
Aug 23, 2022
hauntsaninja
left a comment
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Thank you and thank you BvB93!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Here is a alternative PR of #11216, which merged
master. All respects go to @BvB93.This PR is useful when the original author has no spare time to do merge.
Also, I'm happy to make the PR directly to the original fork.
@BvB93 @hauntsaninja